Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/options #140

Merged
merged 15 commits into from
Jul 27, 2021
Merged

Feature/options #140

merged 15 commits into from
Jul 27, 2021

Conversation

mapgccv
Copy link
Contributor

@mapgccv mapgccv commented Jul 23, 2021

Indeed the pull request is for direct_interface. Reporting the last messages below:

mapgccv and others added 10 commits July 21, 2021 12:08
Added qualifiedName to all options; this allows users to specify options by either their normal and their fully qualified name (e.g. limits:timelimit). This will allow for a better categorization of options by keeping existing scripts compatible.
Also it improves usability by allowing to print only the options in a given namespace (to be implemented yet).
Any feedback?
names_list can be e.g. "lim:time timelim timelimit",
making timelim and timelimit the 'inline synonyms' for this option
@mapgccv
Copy link
Contributor Author

mapgccv commented Jul 23, 2021

I think OptionSynonym is fine for now, to facilitate finding old names. When we have ASL sorting, it is less necessary.

For sorting, Option 3 is just by using grep. Option 2 is already default. Option 1 can be made by changing the inline_synonyms_ to be a vector and using the 1st element (or just the primary name if none), for example by method name_ASL().

You created the request as to merge into master. Do you want to change it to merge into feature/direct_intf? Or close the request and merge manually. Note that I already merged feature/direct into this branch. Or let me know if I should do it. Also, working on the master as main branch is thinkable if good for any reason, but I'd prefer working on the feature and updating master just sometimes.

@glebbelov glebbelov merged commit 3cb7fc1 into feature/direct_interface Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants